Change in ovirt-engine[ovirt-engine-3.4]: tools: notifier: fix NotificationPropertiesTest.

iheim at redhat.com iheim at redhat.com
Thu Feb 20 15:22:16 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: tools: notifier: fix NotificationPropertiesTest.
......................................................................


tools: notifier: fix NotificationPropertiesTest.

Call NotificationProperties.release() so we do not
get a stale copy of Notification Properties.

(Set default and get instance are not enough
if the current class loader has a copy of
NotificationProperties with an old instance
we will get that one!)

also enable NotificationPropertiesTest to run both under maven and straight
from source thus speeding up testing during development.

Change-Id: Ia3488856323577e3db6c779d86c190e064e15c97
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
---
M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/NotificationPropertiesTest.java
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, approved
  mooli tayer: Verified; Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/24691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3488856323577e3db6c779d86c190e064e15c97
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list