Change in ovirt-engine[ovirt-engine-3.4]: core: prevent illegal disk on custom preview active snapshot

[iheim at redhat.com]

Itamar Heim has submitted this change and it was merged.

Change subject: core: prevent illegal disk on custom preview active snapshot
......................................................................


core: prevent illegal disk on custom preview active snapshot

* SnapshotVmConfigurationHelper:
  avoid marking disks as illegal for a 'PREVIEW' snapshot
  as it represents previous 'Active VM' state.
* SnapshotsManager -> attempToRestoreVmConfigurationFromSnapshot:
  updating images according the specified list when VmConfiguration
  is not available - i.e. custom snapshotting to active VM
  (prevents a possible scenario of missing disks on active VM).

Change-Id: I1561107e05de155f9483e1f8a00d2dba3a4ab342
Bug-Url: https://bugzilla.redhat.com/1064067
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
2 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Daniel Erez: Verified
  Maor Lipchuk: Looks good to me, approved
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/24890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1561107e05de155f9483e1f8a00d2dba3a4ab342
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server