Change in ovirt-engine[ovirt-engine-3.3.4]: restapi: Do not cast memory.used to int

iheim at redhat.com iheim at redhat.com
Tue Feb 25 09:23:42 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: restapi: Do not cast memory.used to int
......................................................................


restapi: Do not cast memory.used to int

Casting the computed value to int caused an overflow
when the value was higher than about 4G. That is not
that unusual nowadays..

Change-Id: I216ac4ef5cf4cfd8cf523a84f75b252e0ce65ad0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1068884
Signed-off-by: Martin Sivak <msivak at redhat.com>
(cherry picked from commit b2f25f9885980779a1fc0f08e360d27355b1ab33)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmStatisticalQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Martin Sivák: Verified
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24958
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I216ac4ef5cf4cfd8cf523a84f75b252e0ce65ad0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.4
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list