Change in ovirt-engine[ovirt-engine-3.3]: core: fix vm pools behavior when DC is missing

iheim at redhat.com iheim at redhat.com
Thu Feb 27 10:06:18 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: core: fix vm pools behavior when DC is missing
......................................................................


core: fix vm pools behavior when DC is missing

When DC is missing (for example force-removed)
then if any vm pools still exist, they don't return in queries, because
of bad join in the view.
 this was fixed by changing the vm_pools_view to use left-join with
storage-pools

in addition, this should not happen, as empty vm pools are not
supported.
but when using force-remove DC, all vms are deleted, but vm-pools are
left.
 this was fixed by changing the stored procedure for remove storage
pool, to remove vm-pools as well, after removing vms.

Change-Id: I47c963b6b66efa05e96cb9b9f80e034d8070a30b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031717
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069219
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/storages_sp.sql
2 files changed, 11 insertions(+), 1 deletion(-)

Approvals:
  Roy Golan: Looks good to me, approved
  Omer Frenkel: Verified
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25010
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I47c963b6b66efa05e96cb9b9f80e034d8070a30b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list