Change in ovirt-engine[master]: core: Use java.util.Objects.equals(Object, Object)

masayag at redhat.com masayag at redhat.com
Sun Jan 5 17:32:42 UTC 2014


Moti Asayag has submitted this change and it was merged.

Change subject: core: Use java.util.Objects.equals(Object, Object)
......................................................................


core: Use java.util.Objects.equals(Object, Object)

This patch replaces usages of
org.ovirt.engine.core.common.utils.ObjectUtils.equals(Object, Object)
with the standard JDK7 java.util.Objects.equals(Object, Object) wherever
possible (i.e., no GWT compilation is required).

This patch helps standardize the code, makes it slightly more readable
to novice oVirt developers and may even save a pico-second of
performance.

Change-Id: Ifbce02996fbba804aeabc54a13f2109656f4a2c6
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UniquePermissionsSet.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationValue.java
5 files changed, 16 insertions(+), 16 deletions(-)

Approvals:
  Allon Mureinik: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbce02996fbba804aeabc54a13f2109656f4a2c6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list