Change in ovirt-engine[master]: webadmin: Add CIDR format validation

mkolesni at redhat.com mkolesni at redhat.com
Wed Jan 8 07:08:36 UTC 2014


Mike Kolesnik has submitted this change and it was merged.

Change subject: webadmin: Add CIDR format validation
......................................................................


webadmin: Add CIDR format validation

CIDR field of a new external subnet will be validated to be in correct
format (IP/prefix - i.e. 10.0.0.0/24 is valid).

Change-Id: Id847a7970113cbb5214cf20720f578fdd3911597
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NewExternalSubnetModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidation.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IpAddressValidation.java
A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidationTest.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
6 files changed, 94 insertions(+), 4 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22691
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id847a7970113cbb5214cf20720f578fdd3911597
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list