Change in ovirt-engine[ovirt-engine-3.3]: core: fix possible NPE on import VM with ram snapshot

iheim at redhat.com iheim at redhat.com
Thu Jan 9 16:25:01 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: core: fix possible NPE on import VM with ram snapshot
......................................................................


core: fix possible NPE on import VM with ram snapshot

In case the memory volumes are set to be imported to storage domain that
no disk was set to be imported to, we were getting NPE in
ImportVmCommand#setDomainsForMemoryImages since we assumed that the
storage domain exists in domain2requiredSize map but it doesn't exists
there in that case.

So from now on we will check whether the storage domain that the memory
volumes are going to be imported to exists in domain2requiredSize or
not and act accordingly in ImportVmCommand#setDomainsForMemoryImages.

Change-Id: I2a574266bdf6f06b7906c1338428071094430a9b
Bug-Url: https://bugzilla.redhat.com/1031371
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a574266bdf6f06b7906c1338428071094430a9b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list