Change in ovirt-engine[master]: webadmin: Extracted common code in manage cluster networks

lvernia at redhat.com lvernia at redhat.com
Tue Jan 14 06:51:50 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Extracted common code in manage cluster networks
......................................................................


webadmin: Extracted common code in manage cluster networks

Code was essentially duplicated in both ClusterNetworkListModel and
NetworkClusterListModel, extracted it into the
ClusterNetworkManageModel for maintainability.

Change-Id: Ifa634f7d8011c25de7b1937984d4ec3627068b31
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java
4 files changed, 136 insertions(+), 237 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22903
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa634f7d8011c25de7b1937984d4ec3627068b31
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list