Change in ovirt-engine[master]: engine: Remove UserSessionTimeOutInvalidationInterval

vszocs at redhat.com vszocs at redhat.com
Wed Jan 15 16:28:07 UTC 2014


Vojtech Szocs has submitted this change and it was merged.

Change subject: engine: Remove UserSessionTimeOutInvalidationInterval
......................................................................


engine: Remove UserSessionTimeOutInvalidationInterval

Currently, there are two different config options
for controlling Engine user session expiration:

 1. UserSessionTimeOutInterval:
    - delay between Engine startup and first
      execution of "cleanExpiredUsersSessions" job
    - allowed values -1,1..100000 (-1 = disable)
    - default value is 30 min

 2. UserSessionTimeOutInvalidationInterval:
    - delay between subsequent executions of
      "cleanExpiredUsersSessions" job
    - allowed values -1,1..100000 (-1 = disable)
    - default value is 30 min

This patch removes the second config option, using
first option to represent both delay intervals.

While it makes little sense to use -1 to disable
Engine user session expiration entirely (as this
essentially generates memory leaks), this patch
preserves the original "-1,1..100000" range for
backward compatibility.

Change-Id: Ic6eb6273653bfffe0d1fa1b8a4dc39e085c19496
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
4 files changed, 2 insertions(+), 11 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6eb6273653bfffe0d1fa1b8a4dc39e085c19496
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list