Change in ovirt-engine[master]: core: Remove storage type parameter in create storage pool V...

tnisan at redhat.com tnisan at redhat.com
Wed Jan 22 13:59:41 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Remove storage type parameter in create storage pool VDS command
......................................................................


core: Remove storage type parameter in create storage pool VDS command

As a part of the effort to remove the type of storage pool, the storage
type parameter in CreateStoragePoolVDSCommand was removed as it's
ignored anyway in VDSM so no need to set it. The method signature in
the broker and VDSM will remain the same for backward compatibility purposes

Change-Id: Ia7efe3008fcdcbde4336ad026249b290b6b3eed5
Relates-To: https://bugzilla.redhat.com/1038053
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateStoragePoolVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateStoragePoolVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
4 files changed, 8 insertions(+), 20 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23293
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7efe3008fcdcbde4336ad026249b290b6b3eed5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list