Change in ovirt-engine[master]: core: cleanup related to removal of memory volumes

ofrenkel at redhat.com ofrenkel at redhat.com
Mon Jan 27 14:30:44 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: core: cleanup related to removal of memory volumes
......................................................................


core: cleanup related to removal of memory volumes

1. Move VmCommand#shouldRemoveMemoryVolumes method to
RemoveSnapshotCommand as it is used only by this class and rename it to
isMemoryVolumeRemoveable

2. Remove RemoveVmCommand#shouldRemoveMemoryVolumes method which is not
in use

Change-Id: I55df977799f79cf91defc111d32b7663a305e60b
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
3 files changed, 10 insertions(+), 16 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/23221
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55df977799f79cf91defc111d32b7663a305e60b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list