Change in ovirt-engine[master]: engine: NetworkValidator uses new validation syntax

mkolesni at redhat.com mkolesni at redhat.com
Tue Jul 1 10:12:46 UTC 2014


Mike Kolesnik has submitted this change and it was merged.

Change subject: engine: NetworkValidator uses new validation syntax
......................................................................


engine: NetworkValidator uses new validation syntax

Refactor the NetworkValidator to use the new validation synatx for
fluently specifying the validation when possible.

In one instance the usage was with "when" instead of unless, since the
positive case was easier to read than the negative one.

Change-Id: I218166e474c0fb046791f9785f68ac39f4767793
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java
1 file changed, 16 insertions(+), 21 deletions(-)

Approvals:
  Mike Kolesnik: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29415
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I218166e474c0fb046791f9785f68ac39f4767793
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list