Change in ovirt-engine[master]: webadmin: Change trigger for VnicProfileWidget ValueChangeEvent

lvernia at redhat.com lvernia at redhat.com
Tue Jul 8 08:58:42 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Change trigger for VnicProfileWidget ValueChangeEvent
......................................................................


webadmin: Change trigger for VnicProfileWidget ValueChangeEvent

VnicProfileWidget used to listen on its nameEditor's ValueChangeEvent
in order to fire a ValueChangeEvent on its own. However, when the
nameEditor's value was changed programmatically from its model,
UiCommonEditorVisitor would call an overload of nameEditor.setValue()
that would set the value without firing a ValueChangeEvent.

This patch registers directly to the model, so that the
programmatical change on the model side would trigger a
ValueChangeEvent of VnicProfileWidget.

Change-Id: I330c38ecedb0df6433491bedaeb7afdc2bd11ae5
Bug-Url: https://bugzilla.redhat.com/1114971
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Lior Vernia: Verified



-- 
To view, visit http://gerrit.ovirt.org/29526
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I330c38ecedb0df6433491bedaeb7afdc2bd11ae5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list