Change in ovirt-engine[master]: webadmin: Remove unsafe List casts from Networks subtabs

lvernia at redhat.com lvernia at redhat.com
Thu Jul 10 10:53:44 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Remove unsafe List casts from Networks subtabs
......................................................................


webadmin: Remove unsafe List casts from Networks subtabs

Many of these unsafe casts existed, which would cause trouble now that
columns are being sorted (and items are stored as SortedSet).

Change-Id: Ifd4c8583ae872cee936eb9de689c1a8639ed73d5
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkProfileListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java
5 files changed, 76 insertions(+), 112 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Lior Vernia: Verified



-- 
To view, visit http://gerrit.ovirt.org/28669
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd4c8583ae872cee936eb9de689c1a8639ed73d5
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list