Change in ovirt-engine[master]: webadmin: SetupNetwork>edit network(with pencil)>can't edit ...

[alkaplan at redhat.com]

Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: SetupNetwork>edit network(with pencil)>can't edit network
......................................................................


webadmin: SetupNetwork>edit network(with pencil)>can't edit network

EnumRadioEditor used the global eventBus to fire ValueChangeEvent.
Since UiCommonEditorVisitor subscribes all the editors of type
HasValueChangeHandlers to this event- all the instances of EnumRadioEditor
were subscribed to the same eventBus.
Therefore, each instance pf EnumRadioEditor got the value change events
of the other instances- which caused wrong behaviour and in some cases
ClassCasException.
To fix the issue a separate handlerManger is used for each instance of
EnumRadioEditor.

Note: addValueChangeHandler(..) cannot register to the valueChangeHanlder
of the peer since the peer's 'value' is all the list of enum-items and not
just the selected item as desired.

Change-Id: I83c330b8340ba1cf6b2382877b23d07c25fc1afb
Bug-Url: https://bugzilla.redhat.com/1108014
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java
4 files changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29735
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I83c330b8340ba1cf6b2382877b23d07c25fc1afb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server