Change in ovirt-engine[master]: core: Check messages when CDA succeeds

amureini at redhat.com amureini at redhat.com
Sun Jul 13 13:25:24 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Check messages when CDA succeeds
......................................................................


core: Check messages when CDA succeeds

Improved CanDoActionTestUtils.runAndAssertCanDoActionSuccess to check
not only that canDoAction() returned true, but also that it did not add
any messages to the return value.

Change-Id: I72d4ee52679db995aba9155c71954c13be613fa4
Signed-off-by: Allon Mureinik <amureini at redhat.com>
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29807
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I72d4ee52679db995aba9155c71954c13be613fa4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list