Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Unable to scroll down template list usi...

tnisan at redhat.com tnisan at redhat.com
Tue Jul 15 14:03:43 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: userportal,webadmin: Unable to scroll down template list using IE9
......................................................................


userportal,webadmin: Unable to scroll down template list using IE9

Three issues:
1: when clicking the scrollbar next to the template selection, IE9 did not fire
 a click event properly (a known IE9 bug). Fixed by attaching the listeners to
 the parent element (the whole suggestion box).

2: when using up/down keys, the proper template has been selected, but the view
 was not scrolled into it. Fixed by scrolling into the view after pressing
 arrow keys and also when opening the suggestions.

3: tweaked the CSS a bit so the content of the suggestions are not shifted

Tested on IE9 and FF.

Change-Id: I93312c75f7605cb007ae395d900ef8ced35c6b14
Bug-Url: https://bugzilla.redhat.com/1100194
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
2 files changed, 52 insertions(+), 4 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Alexander Wels: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29851
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I93312c75f7605cb007ae395d900ef8ced35c6b14
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list