Change in ovirt-engine[ovirt-engine-3.5]: aaa: change code of AddUser and AddGroup

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Jul 18 07:33:28 UTC 2014


Piotr Kliczewski has submitted this change and it was merged.

Change subject: aaa: change code of AddUser and AddGroup
......................................................................


aaa: change code of AddUser and AddGroup

removing the check from canDoAction to check if entity exists
in directory as these checks are done both by rest-api and gui.

Bug-Url: https://bugzilla.redhat.com/1120609
Topic: AAA
Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SyncUsers.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddGroupParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddUserParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java
13 files changed, 127 insertions(+), 190 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Yair Zaslavsky: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If841c8d30d6ab2c5d06b1637cde93cfc65598a96
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list