Change in ovirt-engine-cli[master]: cli: Don't fail when there is no tty

juan.hernandez at redhat.com juan.hernandez at redhat.com
Fri Jul 18 07:38:05 UTC 2014


Juan Hernandez has submitted this change and it was merged.

Change subject: cli: Don't fail when there is no tty
......................................................................


cli: Don't fail when there is no tty

Currently we always try to open the /dev/tty device, but this will fail
in environments where there isn't a terminal available, like when
running from a cron script. This patch changes the CLI so that it won't
crash in these situations.

Change-Id: Ie68152e171248b5b18296773b2cd5acaf98d34f3
Bug-Url: https://bugzilla.redhat.com/1119412
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/cli/platform/posix/terminal.py
1 file changed, 26 insertions(+), 14 deletions(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30238
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie68152e171248b5b18296773b2cd5acaf98d34f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list