Change in ovirt-engine[master]: core: fix race when removing memory volumes during Live Merge

amureini at redhat.com amureini at redhat.com
Fri Jul 18 18:42:47 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: core: fix race when removing memory volumes during Live Merge
......................................................................


core: fix race when removing memory volumes during Live Merge

Memory volume removal was not tracked as a child command, and its
completion would trigger endAction of RemoveSnapshotCommand before the
tasks run by ExecutionHandler were complete.  Instead, use the newer
RemoveMemoryVolumesCommand during Live Merge, which Executionhandler can
coordinate.

Change-Id: I12e317ada7159101cc5349e9a084b7f316493048
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
2 files changed, 17 insertions(+), 5 deletions(-)

Approvals:
  Ravi Nori: Looks good to me, but someone else must approve
  Greg Padgett: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/29804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I12e317ada7159101cc5349e9a084b7f316493048
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list