Change in ovirt-engine[ovirt-engine-3.5]: core: update VirtIO-SCSI device on next run VM snapshot

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Jul 22 08:16:54 UTC 2014


Piotr Kliczewski has submitted this change and it was merged.

Change subject: core: update VirtIO-SCSI device on next run VM snapshot
......................................................................


core: update VirtIO-SCSI device on next run VM snapshot

* Added an 'EditableDeviceOnVmStatusField' annotation for
  'virtioScsiEnabled' (in VmManagementParametersBase).
* Consequently, removed canDo validation in UpdateVmCommand.

Change-Id: Ic1ee50f25e71d4540ebb6ab60250b9cfa5985ac4
Bug-Url: https://bugzilla.redhat.com/1035289
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingVmInstanceTypeManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
5 files changed, 31 insertions(+), 29 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Daniel Erez: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30044
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1ee50f25e71d4540ebb6ab60250b9cfa5985ac4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list