Change in ovirt-engine[master]: userportal, webadmin: show advanced options on validation error

[tjelinek at redhat.com]

Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal,webadmin: show advanced options on validation error
......................................................................


userportal,webadmin: show advanced options on validation error

When there was a validation error in the new/edit VM dialog while only the
basic mode was visible, it was not obvious what the problem is.

The new behavior is this:
- if there is a validation error and the invalid widget is visible in the
  current screen, do not show the advanced options
- if there is a validation error and the invalid widget is not visible, turn on
  the advanced options so the widget will be visible

To support this, the following changes had to be made:
- added the method isValid to HasValidation
- implemented this method in the needed widgets
- added the support of HasValidation also to the EntityModelWidgetWithInfo and
  DetachableWidget
- added a method getInvalidWidgets to DialogTab to find all the invalid widgets

Beside this also some small fixes has been done, namely:
- added the proper validation of the initial run tab
- fixed the validation of the system tab
- extracted and cleaned up the resetting of the tab validity

Change-Id: I1b419b560fe1e0bc0c8114d2a34f0bc930756aa0
Bug-Url: https://bugzilla.redhat.com/1085380
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasValidation.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/WidgetWithLabelEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/BaseEntityModelDetachableWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidgetWithLabel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/popup/AbstractVmBasedPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportFcpStorageView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportIscsiStorageView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
17 files changed, 253 insertions(+), 35 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Alexander Wels: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b419b560fe1e0bc0c8114d2a34f0bc930756aa0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server