Change in ovirt-engine[master]: core: GetAllFromVmStaticByStoragePoolId - remove unneeded join

laravot at redhat.com laravot at redhat.com
Mon Jun 2 14:49:19 UTC 2014


Liron Ar has submitted this change and it was merged.

Change subject: core: GetAllFromVmStaticByStoragePoolId - remove unneeded join
......................................................................


core: GetAllFromVmStaticByStoragePoolId - remove unneeded join

remove unneeded join with vm_dynamic, vm_dynamic and vm_static should be
added in the same transacation when adding a vm. I assume that this join
was added to avoid querying templates, but it's unneeded as we already
check the entity type in the query without performing that probably more
expensive operation.

Change-Id: I4fd372a5c4018d3c7bb7e38e1375fa198a14b572
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M packaging/dbscripts/vms_sp.sql
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Liron Ar: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24716
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fd372a5c4018d3c7bb7e38e1375fa198a14b572
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list