Change in ovirt-engine[ovirt-engine-3.4]: core: fix duplicate smartcards on template update

oourfali at redhat.com oourfali at redhat.com
Thu Jun 5 14:14:28 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: core: fix duplicate smartcards on template update
......................................................................


core: fix duplicate smartcards on template update

When updating template, if smart card is enabled,
a new device was created and there was no check for existing device.

fixed to check if device already exist before add.
also added a script to eliminate any existing duplicates.

Change-Id: I14e6779c5c85b514cb953b771c68c5ac1acaafcb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1101447
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
A packaging/dbscripts/upgrade/03_04_0790_remove_duplicate_smartcards.sql
2 files changed, 13 insertions(+), 7 deletions(-)

Approvals:
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I14e6779c5c85b514cb953b771c68c5ac1acaafcb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list