Change in ovirt-engine[master]: userportal, webadmin: Remove redundant scroll bar in VM gener...

tjelinek at redhat.com tjelinek at redhat.com
Fri Jun 6 06:23:06 UTC 2014


Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal,webadmin: Remove redundant scroll bar in VM general tab
......................................................................


userportal,webadmin: Remove redundant scroll bar in VM general tab

The ProfilesInstanceTypeEditor had the vertical size hardcoded and was wrapped
by a ScrollPanel. This caused the redundant scroll bar in the VM general tab to
appear.
Fixed by removing the ScrollPanel since in all other tabs in the VM dialog the
scrolling is handled by the dialog itself - this change makes the behavior
consistent with the rest of the tabs.

It has been already fixed in http://gerrit.ovirt.org/#/c/26169 but has been
accidentally introduced back in http://gerrit.ovirt.org/#/c/24594 so this
patch removes it again.

Change-Id: I03f31624feaa23b37006310d365d57e717d4bbb0
Bug-Url: https://bugzilla.redhat.com/1047883
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Greg Sheremeta: Looks good to me, but someone else must approve
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/28298
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03f31624feaa23b37006310d365d57e717d4bbb0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list