Change in ovirt-engine[master]: core: Throwing exception instead of handle fault

amureini at redhat.com amureini at redhat.com
Sun Jun 29 07:40:07 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Throwing exception instead of handle fault
......................................................................


core: Throwing exception instead of handle fault

CommandBase -> executeWithoutTransaction already handles a
VdcBLLException by calling processExceptionToClient.
So AddStorageServerConnectionCommand should throw an
exception with a right error message, and this way both UI and REST api
get the same response.

Change-Id: I3e6b8282d9e2cdd6e17f21a2ef034041d68d09fc
Bug-Url: https://bugzilla.redhat.com/1108164
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
1 file changed, 7 insertions(+), 14 deletions(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Idan Shaby: Verified



-- 
To view, visit http://gerrit.ovirt.org/29259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e6b8282d9e2cdd6e17f21a2ef034041d68d09fc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list