Change in ovirt-engine[master]: core: extract parameters initialization from vdsUpEvent

ofrenkel at redhat.com ofrenkel at redhat.com
Tue Mar 4 09:47:53 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: core: extract parameters initialization from vdsUpEvent
......................................................................


core: extract parameters initialization from vdsUpEvent

Extract the part that initialize the parameters for the migrate VM to
server commands from VdsEventListener#vdsUpEvent to make it more
readable.

In addition, change MigrateBrokerVDSCommand to create the migrate-info
map right before invoking VDSM verb as this information is not needed
until then and we do not need to hold it as class member.

Minor cleanup in MigrateVDSCommand is also included in this patch.

Change-Id: I54501c64f9b0ff3cd2bb80d457a597d01328b8d5
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
4 files changed, 43 insertions(+), 33 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/24798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54501c64f9b0ff3cd2bb80d457a597d01328b8d5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list