Change in ovirt-engine[master]: webadmin: Fix Default OS selection for PPC

tjelinek at redhat.com tjelinek at redhat.com
Wed Mar 5 08:48:01 UTC 2014


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: Fix Default OS selection for PPC
......................................................................


webadmin: Fix Default OS selection for PPC

The change 23809 introduced a problem with the default OS for PPC64,
since the id 0 was fixed in the AsyncDataProvider class. This change
was supposed to fix a possible issue, that happens when the OS id added
to a VM is missing in the OSInfo property file. I reverted the solution
that was using the class MapWithDafults, because there are two default
OSes (one for each architecture), not only one.
I couldn't figure out how to fix this issue, maybe when starting the
system and exit with an error or show error on event log. It deserves
more discussion.

Change-Id: I02843c1af1b3aecf2d3966bf836395550b0be554
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1062344
Signed-off-by: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
---
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/MapWithDefaults.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
3 files changed, 12 insertions(+), 54 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02843c1af1b3aecf2d3966bf836395550b0be554
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list