Change in ovirt-engine[master]: engine: Add action type for snapshot.

mlipchuk at redhat.com mlipchuk at redhat.com
Thu Mar 6 16:11:18 UTC 2014


Maor Lipchuk has submitted this change and it was merged.

Change subject: engine: Add action type for snapshot.
......................................................................


engine: Add action type for snapshot.

The following patch changes the API between the client and the engine
when preview/commit or undo a snapshot.
The patch introduces the following changes:
* Adding an enum which distinguishes between several operations on a snapshot:
  Undo
  Commit
  Restore From Stateless status
* Use of snapshot instead snapshotId
* Changing the client to call to the engine with the operation on snapshot
* Removing snapshotId from the constructor of the parameters, since the
snapshot is only on a VM, and there is no reason to transfer it, but
better that the engine will fetch it, it self.
The reason for this change, is for REST operations to be implemented in
the following patches

Change-Id:If877befc5058c3412ae3d3731d5beacbc09e5c97
Related to Bug-Url: https://bugzilla.redhat.com/867339
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllSnapshotsParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SnapshotActionEnum.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResourceTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
9 files changed, 99 insertions(+), 59 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Maor Lipchuk: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20420
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If877befc5058c3412ae3d3731d5beacbc09e5c97
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520 at yahoo.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list