Change in ovirt-engine[ovirt-engine-3.4.0]: restapi: Don't assume that Lists are ArrayLists

sbonazzo at redhat.com sbonazzo at redhat.com
Fri Mar 7 12:42:14 UTC 2014


Sandro Bonazzola has submitted this change and it was merged.

Change subject: restapi: Don't assume that Lists are ArrayLists
......................................................................


restapi: Don't assume that Lists are ArrayLists

Currently there are a few places where we assume that the result
returned by the backend is an ArrayList. This isn't necessary true, in
particular it isn't true for lists of users and groups returned by
directories, as they will be special empty lists. This patch changes the
RESTAPI so that it uses the List interface instead of the ArrayList
class.

Change-Id: Iff2d2a7b558f111312b6299ce7ed95993deb68ca
Bug-Url: https://bugzilla.redhat.com/1073486
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit 975457b92d5b6f02d845c5410ae11d3d186a3635)
(cherry picked from commit a49cef416fe9638fd916d73cb896e442f4c9873c)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainUsersResource.java
3 files changed, 3 insertions(+), 9 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Juan Hernandez: Verified; Looks good to me, approved
  Roy Golan: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25512
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff2d2a7b558f111312b6299ce7ed95993deb68ca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list