Change in ovirt-engine[master]: core: Change Vm status on destroy only for SRC VMs

ofrenkel at redhat.com ofrenkel at redhat.com
Tue Mar 11 13:37:30 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: core: Change Vm status on destroy only for SRC VMs
......................................................................


core: Change Vm status on destroy only for SRC VMs

when stopping a migrating VMs, do the state change only if the VM is
really running on SRC host.

StopVm shoots 2 destroy commands incase the vm is migrating - 1 for the
DST and one for the SRC. after the DST is destroy the Vm must not be
DOWN, otherwise an interleaving RunVm could start
it while we're about to shoot the next stop.

that solution is reverting change
I6109ef0ea4869b59a93be6fef4b0c3cff50da62e
which implemented that with an engine lock

Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac
Bug-url: https://bugzilla.redhat.com/1064859
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Roy Golan: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25568
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I422e75fc863e3416261a4d3eaef4312dc933bdac
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list