Change in ovirt-engine-sdk-java[master]: codegen: Overload methods for new headers

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Mar 13 10:38:29 UTC 2014


Juan Hernandez has submitted this change and it was merged.

Change subject: codegen: Overload methods for new headers
......................................................................


codegen: Overload methods for new headers

Currently the code generator generates a single method containing
parameters for all the available headers. This means that when a new
header is added the old method will be removed and a new one will be
created with one additional parameter. This breaks backwards
compatibility. This patch modifies the code generator so that the old
method will be preserved and a new one will be added with the additional
parameter for the new header.

Change-Id: I1c035983a6f74aec7dd611f2aaa4ba1d1581594e
Bug-Url: https://bugzilla.redhat.com/1073417
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/documentation/DocsGen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/AbstractOverloadableTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionActionMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionActionMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionAddMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionAddMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/CollectionListMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodWithBodyTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/DeleteMethodWithBodyTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ExtraMethodParameterTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ExtraMethodParameterTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ListMethodTemplate.java
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/MethodParameterTemplate
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/MethodParameterTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceActionMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ResourceActionMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionAddMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionAddMethodTemplate.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/SubCollectionListMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/UpdateMethodTemplate
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/UpdateMethodTemplate.java
A ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/LinkUtils.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/utils/StringUtils.java
25 files changed, 855 insertions(+), 630 deletions(-)

Approvals:
  Michael Pasternak: Looks good to me, approved
  Juan Hernandez: Verified



-- 
To view, visit http://gerrit.ovirt.org/25521
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c035983a6f74aec7dd611f2aaa4ba1d1581594e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520 at yahoo.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>



More information about the Engine-commits mailing list