Change in ovirt-engine[master]: core: move constant strings in ovf to OvfProperties

ahadas at redhat.com ahadas at redhat.com
Sun Mar 16 08:45:47 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: core: move constant strings in ovf to OvfProperties
......................................................................


core: move constant strings in ovf to OvfProperties

Most of the Strings which are part of the OVF files appear explicitly
in both the reader and writer classes. It is wrong because they have to
be the same in both places. So in this patch I move many Strings like
that to the OvfProperties class as constants and the OVF readers and
writers now reference those constants.

Change-Id: Idc40102b107d510e04f10f45f0b7e4838fd4c706
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
7 files changed, 136 insertions(+), 93 deletions(-)

Approvals:
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25679
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc40102b107d510e04f10f45f0b7e4838fd4c706
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list