Change in ovirt-engine[master]: webadmin: Show Guide Me before vNIC creation

lvernia at redhat.com lvernia at redhat.com
Thu Mar 20 12:58:34 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Show Guide Me before vNIC creation
......................................................................


webadmin: Show Guide Me before vNIC creation

There's no real need to wait for the vNIC creation to finish before
showing the Guide Me dialog; if the creation succeeds then it could
happen asynchronously while the user deals with the Guide Me dialog
(I'm unaware of any interdependence between the operations), and if it
fails then an error dialog will popup up anyway (and on top of the
Guide Me dialog rather than under it).

Change-Id: If4bebb56613ebaed67377489448501ba9642adf6
Bug-Url: https://bugzilla.redhat.com/1066461
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 20 insertions(+), 9 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4bebb56613ebaed67377489448501ba9642adf6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list