Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Show Guide Me before vNIC creation

oourfali at redhat.com oourfali at redhat.com
Thu Mar 20 14:07:57 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: webadmin: Show Guide Me before vNIC creation
......................................................................


webadmin: Show Guide Me before vNIC creation

There's no real need to wait for the vNIC creation to finish before
showing the Guide Me dialog; if the creation succeeds then it could
happen asynchronously while the user deals with the Guide Me dialog
(I'm unaware of any interdependence between the operations), and if it
fails then an error dialog will popup up anyway (and on top of the
Guide Me dialog rather than under it).

Change-Id: If4bebb56613ebaed67377489448501ba9642adf6
Bug-Url: https://bugzilla.redhat.com/1066461
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 20 insertions(+), 9 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Lior Vernia: Verified



-- 
To view, visit http://gerrit.ovirt.org/25936
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4bebb56613ebaed67377489448501ba9642adf6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list