Change in ovirt-engine[ovirt-engine-3.4]: engine: Can't add user without system level admin permission

[oourfali at redhat.com]

Oved Ourfali has submitted this change and it was merged.

Change subject: engine: Can't add user without system level admin permission
......................................................................


engine: Can't add user without system level admin permission

This patch fixes a regression introduced at Ib62e1c051bc78b8a9ec0f32e6ba4eb9484242591

1. Introducing a new permission of adding non existing users - this is required, as the other options are:
a. Using the existing "manipulate users" permission - this will cause a regression, allowing roles to add users directly without the need to use the add permissions dialogs.
b. Removing the permission check for non existing users/groups - this will break https://bugzilla.redhat.com/923100

2. The new permission is added to all the roles that have manipulate permissions manipulation -
this is done in order to fix the above regression.

Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c
Bug-Url: https://bugzilla.redhat.com/1070651
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
A packaging/dbscripts/upgrade/03_04_0700_add_missing_manipulate_users_permissions.sql
9 files changed, 44 insertions(+), 4 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, approved
  Ravi Nori: Verified



-- 
To view, visit http://gerrit.ovirt.org/25482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server