Change in ovirt-engine[master]: core: minor cleanup in migration related classes

ahadas at redhat.com ahadas at redhat.com
Mon Mar 24 07:08:58 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: core: minor cleanup in migration related classes
......................................................................


core: minor cleanup in migration related classes

- Remove redundant setting of migrating-to-vds field in MigrateVmCommand
- Remove '_' prefix in MigrateVDSCommandParameters field names
- Fix indentation in MigrateVDSCommand
- Extract the invocation of MigrateVDSCommand from
  MigrateVmCommand#perform to separate method in order to make the
  perform method more readable

Change-Id: If7e8f60d8e9accf2618ed10fa17f74e56e0d1ae9
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java
3 files changed, 31 insertions(+), 33 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/25572
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7e8f60d8e9accf2618ed10fa17f74e56e0d1ae9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list