Change in ovirt-engine[ovirt-engine-3.4]: webadmin: class cast exception in AdElementListModel

oourfali at redhat.com oourfali at redhat.com
Sun Mar 30 05:37:38 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: webadmin: class cast exception in AdElementListModel
......................................................................


webadmin: class cast exception in AdElementListModel

A regression has been introduced by fc169177820737e984c65d930056be7e2e85d289.

If there is no domain configured the search query used to return ArrayList but
now it returns a Collections.emptyList() while the AdElementListModel tries to
cast it to ArrayList which fails.

Fixed by casting it to more general Collection.

Change-Id: Ib3e3d4b18227027ca31aaab80f403c1fd813fee6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1081895
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Tomas Jelinek: Verified
  Gilad Chaplik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26190
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3e3d4b18227027ca31aaab80f403c1fd813fee6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list