Change in ovirt-engine[master]: host-deploy: node-upgrade: apply artificial eof for vdsm-upg...

yzaslavs at redhat.com yzaslavs at redhat.com
Mon Mar 31 09:56:46 UTC 2014


Yair Zaslavsky has submitted this change and it was merged.

Change subject: host-deploy: node-upgrade: apply artificial eof for vdsm-upgrade
......................................................................


host-deploy: node-upgrade: apply artificial eof for vdsm-upgrade

apply artificial end-of-file.

there is no way in java to use non blocking
InputStream.

there is no way to interrupt the blocking.

and we cannot terminate thread as the connection
pool will get messy.

so we should detect eof based on data.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1080594
Change-Id: I093357933d2f10c0d90864f53977b832a58dafbd
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
1 file changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Alon Bar-Lev: Verified
  Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Barak Azulay: Looks good to me, but someone else must approve
  Yair Zaslavsky: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26122
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I093357933d2f10c0d90864f53977b832a58dafbd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list