Change in ovirt-engine[master]: core: Fix AuditLog check for existing log entries

emesika at redhat.com emesika at redhat.com
Mon Mar 31 11:11:42 UTC 2014


Eli Mesika has submitted this change and it was merged.

Change subject: core: Fix AuditLog check for existing log entries
......................................................................


core: Fix AuditLog check for existing log entries

The audit log check for existing element in the cache,
If the entry exist, then there is no need for another log message.
This is how the anti flooding mechanism works.
For that we use Infinispan cache and the putIfAbsent method,
which updates the lifespan(time to keep in cache).
For our use of the cache, we don't want this update.

The fix changes the putIfAbsent and replace it with two othe API methods,
Contains and Put.

Change-Id: I94b777911eb1ff667be3dc8362bde5746d84824c
Bug-Url: https://bugzilla.redhat.com/1079920
Signed-off-by: Kobi Ianko <kobi at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java
1 file changed, 11 insertions(+), 6 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, approved
  Kobi Ianko: Verified
  Yair Zaslavsky: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/26028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94b777911eb1ff667be3dc8362bde5746d84824c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc at redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list