Change in ovirt-engine[master]: frontend: Always assume GuestAgent to be present for SSO req...

tjelinek at redhat.com tjelinek at redhat.com
Mon May 5 09:12:42 UTC 2014


Tomas Jelinek has submitted this change and it was merged.

Change subject: frontend: Always assume GuestAgent to be present for SSO requests
......................................................................


frontend: Always assume GuestAgent to be present for SSO requests

Motivation: There are already so many different names for the guest
agent and their versions that it is an impossible task for the engine
to maintain that. And it's unreliable for such cases. Besides that,
it doesn't tell the engine anyway if there's SSO support or not. Using
the application list to identify the guest agent version is not a good
idea.

Instead we'll check in VDSM whether or not the guest agent is there,
since it gets a heartbeat it'll know early enough if it is responsive
and only then forward the desktopLogin request.
http://gerrit.ovirt.org/27147

Change-Id: Iac7271b4284cc40868ac21ce7eaa4f9ac5e19371
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Vinzenz Feenstra: Verified
  Frank Kobzik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/27143
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac7271b4284cc40868ac21ce7eaa4f9ac5e19371
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list