Change in ovirt-engine[master]: engine: adding base_interface column to vds_interface table

alkaplan at redhat.com alkaplan at redhat.com
Wed May 7 07:15:07 UTC 2014


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: adding base_interface column to vds_interface table
......................................................................


engine: adding base_interface column to vds_interface table

We should accept vlan devices identified by any name (and not only
baseIface.vlanId)
Therefore the baseInterface name cannot longer be determined from the
vlan device name.
If the interface is vlan the columns will contain the base interface
name.

Change-Id: I87ac5121b9e7d3b74f5557336e5d504ef91b7702
Bug-Url: https://bugzilla.redhat.com/1091863
Bug-Url: https://bugzilla.redhat.com/999975
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Vlan.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/03_05_0370_add_base_interface_column_to_vds_interfaces.sql
8 files changed, 55 insertions(+), 8 deletions(-)

Approvals:
  Mike Kolesnik: Looks good to me, approved
  Eli Mesika: Looks good to me, but someone else must approve
  Alona Kaplan: Verified



-- 
To view, visit http://gerrit.ovirt.org/26605
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87ac5121b9e7d3b74f5557336e5d504ef91b7702
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list