Change in ovirt-engine[master]: core: removing lock from DetachStorageDomainFromPoolCommand

laravot at redhat.com laravot at redhat.com
Tue May 20 13:41:45 UTC 2014


Liron Ar has submitted this change and it was merged.

Change subject: core: removing lock from DetachStorageDomainFromPoolCommand
......................................................................


core: removing lock from DetachStorageDomainFromPoolCommand

The lock on the domain id when detaching it was added in change
I4ee8cd4b64393d195fe45349f49996e45ce09f0f but it's currently incorrect
because the detach command is also executed from commands that already
take the lock on the storage domain, which will lead to a failure.
We need to pass the command context to avoid that situation, but that
will be inspected in a further patch - right now this patch returns the
situation to it's previous state.

Change-Id: I90b801416bb932ddc08dbb2d626882fc60895826
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java
1 file changed, 0 insertions(+), 13 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Liron Ar: Verified



-- 
To view, visit http://gerrit.ovirt.org/27938
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I90b801416bb932ddc08dbb2d626882fc60895826
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list