Change in ovirt-engine[master]: webadmin: Repair disallow RO in UI

derez at redhat.com derez at redhat.com
Tue May 20 14:06:03 UTC 2014


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: Repair disallow RO in UI
......................................................................


webadmin: Repair disallow RO in UI

Qemu currently does not support direct-LUN disks connected using
VirtIO-SCSI. This patch blocks this option from UI when
adding/editing/attaching a direct-LUN disk with VirtIO-SCSI interface to a VM.
This wasn't checked in Add/Edit Disk to Vm dialog, nor in Attach table.
IDE behaviour was changed to comply with this behaviour in this patch as well.
This patch also removes un-needed verfication for IDE disk.

Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90
Bug-Url: https://bugzilla.redhat.com/1097754
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 21 insertions(+), 21 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27665
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb1923d03785be7f228076e12f4865242aed5c90
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list