Change in ovirt-engine[master]: core: simplify CommonVmPoolWithVmsCommand#executeCommand

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core: simplify CommonVmPoolWithVmsCommand#executeCommand
......................................................................


core: simplify CommonVmPoolWithVmsCommand#executeCommand

The method CommonVmPoolWithVmsCommand#executeCommand was too long with a
lot of responsibilities inside. This patch extracts the name generation
for the VMs and the creation of the parameters for
AddVmAndAttachToPool to separate methods.

In addition, we are now taking the pool's name from the VmPool object in
the parameters class as we should do, and not from the VM object.

Change-Id: I10b7bd20780f734cbe7c9b7c102b2e5442a722ac
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NameForVmInPoolGenerator.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NameForVmInPoolGeneratorTest.java
3 files changed, 83 insertions(+), 45 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/26363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I10b7bd20780f734cbe7c9b7c102b2e5442a722ac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server