Change in ovirt-engine[master]: engine : Set endAction try again to false on failure

yzaslavs at redhat.com yzaslavs at redhat.com
Thu Nov 6 13:03:53 UTC 2014


Yair Zaslavsky has submitted this change and it was merged.

Change subject: engine : Set endAction try again to false on failure
......................................................................


engine : Set endAction try again to false on failure

On failure of commands with handlers, if no handler 
has been executed the endWithFailure is not invoked
on the handlers. This can leave setEndActionTryAgain to
true causing AsyncTaskManager to continuously wait for
commands completion. In such cases the CommandBase should
set the setEndActionTryAgain to false so the command
can converge.

Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942
Bug-Url: https://bugzilla.redhat.com/1159325
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Ravi Nori: Verified
  Yair Zaslavsky: Looks good to me, approved
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/34702
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list