Change in ovirt-engine[master]: core: extract balloon validation in import vm

ahadas at redhat.com ahadas at redhat.com
Thu Nov 13 09:50:19 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: core: extract balloon validation in import vm
......................................................................


core: extract balloon validation in import vm

It is better to extract the validation from the canDoAction command for
2 reasons:
1. Readability - to make the canDoAction method more readable
2. Testability - to make the command more testable

Change-Id: I152a9b96e9804ba66bc967f2754a33c346222674
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
2 files changed, 23 insertions(+), 9 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/35087
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I152a9b96e9804ba66bc967f2754a33c346222674
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list