Change in ovirt-engine[master]: core: remove possiblity of replacements being null

lvernia at redhat.com lvernia at redhat.com
Sun Nov 16 14:35:06 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: core: remove possiblity of replacements being null
......................................................................


core: remove possiblity of replacements being null

otherwise every caller would have check for nullity (which was
violated), and such testing is not needed at all, since this field can
be properly initialized every time.

Change-Id: Ice3c566c4e77204c3d6eb0e2b24ec68210cbc8d7
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ValidationResultMatchers.java
4 files changed, 13 insertions(+), 15 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice3c566c4e77204c3d6eb0e2b24ec68210cbc8d7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list