Change in ovirt-engine[master]: engine: Use proper units in Storage QoS when talking to VDSM

rgolan at redhat.com rgolan at redhat.com
Tue Nov 18 10:19:12 UTC 2014


Roy Golan has submitted this change and it was merged.

Change subject: engine: Use proper units in Storage QoS when talking to VDSM
......................................................................


engine: Use proper units in Storage QoS when talking to VDSM

The engine used Mbps and VDSM expects B/s. This patch changes
the engine side to use MB/s (as is more common when dealing with
storage) and properly translates that to Bytes when sending the
value to VDSM.

Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621
Signed-off-by: Martin Sivák <msivak at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
3 files changed, 20 insertions(+), 14 deletions(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list