Change in ovirt-engine[master]: restapi: copy instance type fields to the VM

juan.hernandez at redhat.com juan.hernandez at redhat.com
Fri Nov 21 12:57:02 UTC 2014


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: copy instance type fields to the VM
......................................................................


restapi: copy instance type fields to the VM

As a sonsequence of the https://bugzilla.redhat.com/1149663 the instance type
fields are not copyed to the VM on server anymore and the frontends
(WA/UP/REST) need to take care of it.

More specifically it works like this:

If only the instance type is selected, it has to copy it's properties to the
newly created VM (on VM level this can be overridden)

If both the template and the instance type is selected, the instance type
overrides the template.

When copying the parameters from instance type to the VM, only the ones which
are supported on the target cluster/OS are taken into account.

Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15
Bug-Url: https://bugzilla.redhat.com/1149663
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
4 files changed, 207 insertions(+), 121 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Juan Hernandez: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35129
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list